From 30457cd81a3b7604b663c5fe220eba37c19bd3ae Mon Sep 17 00:00:00 2001
From: zuckerberg <5-zuckerberg@users.noreply.git.neet.dev>
Date: Mon, 12 Jul 2021 18:23:48 -0400
Subject: [PATCH] wip

---
 src/context.cpp |  28 +++++-----
 src/types.cpp   | 142 +++++++++++++++++++++++++++++++++---------------
 src/types.h     |  29 +++++++---
 3 files changed, 133 insertions(+), 66 deletions(-)

diff --git a/src/context.cpp b/src/context.cpp
index 1ed70a8..fb5c07b 100644
--- a/src/context.cpp
+++ b/src/context.cpp
@@ -51,7 +51,7 @@ Value Context::eval(peg::Ast& ast) {
     for (int i=0; i<ast.nodes.size(); i++) {
       exprs.args.push_back(getValue(eval(*nodes[i])));
     }
-    return Value(exprs);
+    return exprs;
   } else if (ast.name == "AdditionExpr") {
     Value value = getValue(eval(*nodes[0]));
     for (int i=1; i<nodes.size(); i+=2) {
@@ -59,9 +59,9 @@ Value Context::eval(peg::Ast& ast) {
       Value v2 = getValue(eval(*nodes[i+1]));
       // TODO: floats
       if (op == 0) {
-        value = Value(value.getInt(cxt) + v2.getInt(cxt));
+        value = value.getInt(cxt) + v2.getInt(cxt);
       } else {
-        value = Value(value.getInt(cxt) - v2.getInt(cxt));
+        value = value.getInt(cxt) - v2.getInt(cxt);
       }
     }
     return value;
@@ -72,9 +72,9 @@ Value Context::eval(peg::Ast& ast) {
       Value v2 = getValue(eval(*nodes[i+1]));
       // TODO: floats
       if (op == 0) {
-        value = Value(value.getInt(cxt) * v2.getInt(cxt));
+        value = value.getInt(cxt) * v2.getInt(cxt);
       } else {
-        value = Value(value.getInt(cxt) / v2.getInt(cxt));
+        value = value.getInt(cxt) / v2.getInt(cxt);
       }
     }
     return value;
@@ -84,22 +84,22 @@ Value Context::eval(peg::Ast& ast) {
     auto v1 = currentScope->getVar(*this, name);
     int op = (*nodes[1]).choice;
     auto v2 = getValue(eval(*nodes[2]));
-    Value result = Value(Nil());
+    Value result = Nil();
     // TODO: floats
     if (op == 0) {
-      result = Value(v1.getInt(cxt) * v2.getInt(cxt));
+      result = v1.getInt(cxt) * v2.getInt(cxt);
     } else if (op == 1) {
-      result = Value(v1.getInt(cxt) % v2.getInt(cxt));
+      result = v1.getInt(cxt) % v2.getInt(cxt);
     } else if (op == 2) {
-      result = Value(v1.getInt(cxt) + v2.getInt(cxt));
+      result = v1.getInt(cxt) + v2.getInt(cxt);
     } else if (op == 3) {
-      result = Value(v1.getInt(cxt) - v2.getInt(cxt));
+      result = v1.getInt(cxt) - v2.getInt(cxt);
     } else if (op == 4) {
-      result = Value(v1.getInt(cxt) & v2.getInt(cxt));
+      result = v1.getInt(cxt) & v2.getInt(cxt);
     } else if (op == 5) {
-      result = Value(v1.getInt(cxt) ^ v2.getInt(cxt));
+      result = v1.getInt(cxt) ^ v2.getInt(cxt);
     } else if (op == 6) {
-      result = Value(v1.getInt(cxt) | v2.getInt(cxt));
+      result = v1.getInt(cxt) | v2.getInt(cxt);
     } else if (op == 7) {
       result = v2;
     }
@@ -141,7 +141,7 @@ Value Context::eval(peg::Ast& ast) {
     }
   } else if (ast.name == "Block") {
     // TODO create new scope
-    Value result = Value(Nil());
+    Value result = Nil();
     for (int i=0; i<ast.nodes.size(); i++) {
       result = eval(*nodes[i]);
     }
diff --git a/src/types.cpp b/src/types.cpp
index 190b25c..4cb3e64 100644
--- a/src/types.cpp
+++ b/src/types.cpp
@@ -53,85 +53,141 @@ Value::Value(const Identifier &identifier) : type(TypeIdentifier) {
 }
 
 Value::Value(const Value &val) {
-  type = val.type;
-  if (isNil()) {
-    value.nil = Nil();
-  } else if (isInt()) {
-    value.int_ = val.value.int_;
-  } else if (isFloat()) {
-    value.float_ = val.value.float_;
-  } else if (isBoolean()) {
-    value.bool_ = val.value.bool_;
-  } else if (isString()) {
-    value.string = new std::string(*val.value.string);
-  } else if (isFunction()) {
-    value.function = new Func(*val.value.function);
-  } else if (isArgs()) {
-    value.args = new Args(*val.value.args);
-  } else if (isIdentifier()) {
-    value.identifier = new Identifier(*val.value.identifier);
+  if (val.isNil()) {
+    *this = Nil();
+  } else if (val.isInt()) {
+    *this = val.value.int_;
+  } else if (val.isFloat()) {
+    *this = val.value.float_;
+  } else if (val.isBoolean()) {
+    *this = val.value.bool_;
+  } else if (val.isString()) {
+    *this = *val.value.string;
+  } else if (val.isFunction()) {
+    *this = *val.value.function;
+  } else if (val.isArgs()) {
+    *this = *val.value.args;
+  } else if (val.isIdentifier()) {
+    *this = *val.value.identifier;
   }
 }
 
 Value& Value::operator=(const Value &rhs) {
-  type = rhs.type;
-  if (isNil()) {
-    value.nil = Nil();
-  } else if (isInt()) {
-    value.int_ = rhs.value.int_;
-  } else if (isFloat()) {
-    value.float_ = rhs.value.float_;
-  } else if (isBoolean()) {
-    value.bool_ = rhs.value.bool_;
-  } else if (isString()) {
-    value.string = new std::string(*rhs.value.string);
-  } else if (isFunction()) {
-    value.function = new Func(*rhs.value.function);
-  } else if (isArgs()) {
-    value.args = new Args(*rhs.value.args);
-  } else if (isIdentifier()) {
-    value.identifier = new Identifier(*rhs.value.identifier);
+  cleanup();
+  if (rhs.isNil()) {
+    *this = Nil();
+  } else if (rhs.isInt()) {
+    *this = rhs.value.int_;
+  } else if (rhs.isFloat()) {
+    *this = rhs.value.float_;
+  } else if (rhs.isBoolean()) {
+    *this = rhs.value.bool_;
+  } else if (rhs.isString()) {
+    *this = *rhs.value.string;
+  } else if (rhs.isFunction()) {
+    *this = *rhs.value.function;
+  } else if (rhs.isArgs()) {
+    *this = *rhs.value.args;
+  } else if (rhs.isIdentifier()) {
+    *this = *rhs.value.identifier;
   }
   return *this;
 }
 
 Value::~Value() {
+  cleanup();
+}
+
+void Value::cleanup() {
   if (isString()) {
+    std::cerr << "string" << std::endl;
     delete value.string;
   } else if (isFunction()) {
+    std::cerr << "func" << std::endl;
     delete value.function;
   } else if (isArgs()) {
+    std::cerr << "args" << std::endl;
     delete value.args;
   } else if (isIdentifier()) {
+    std::cerr << "identifier" << std::endl;
     delete value.identifier;
   }
 }
 
-bool Value::isNil() {
+Value& Value::operator=(Nil rhs) {
+  // cleanup();
+  type = TypeNil;
+  value.nil = rhs;
+  return *this;
+}
+Value& Value::operator=(long rhs) {
+  // cleanup();
+  type = TypeInt;
+  value.int_ = rhs;
+  return *this;
+}
+Value& Value::operator=(double rhs) {
+  // cleanup();
+  type = TypeFloat;
+  value.float_ = rhs;
+  return *this;
+}
+Value& Value::operator=(bool rhs) {
+  // cleanup();
+  type = TypeBoolean;
+  value.bool_ = rhs;
+  return *this;
+}
+Value& Value::operator=(const std::string &rhs) {
+  // cleanup();
+  type = TypeString;
+  value.string = new std::string(rhs);
+  return *this;
+}
+Value& Value::operator=(const Func &rhs) {
+  // cleanup();
+  type = TypeFunction;
+  value.function = new Func(rhs);
+  return *this;
+}
+Value& Value::operator=(const Args &rhs) {
+  // cleanup();
+  type = TypeArgs;
+  value.args = new Args(rhs);
+  return *this;
+}
+Value& Value::operator=(const Identifier &rhs) {
+  // cleanup();
+  type = TypeIdentifier;
+  value.identifier = new Identifier(rhs);
+  return *this;
+}
+
+bool Value::isNil() const {
   return type == TypeNil;
 }
-bool Value::isInt() {
+bool Value::isInt() const {
   return type == TypeInt;
 }
-bool Value::isFloat() {
+bool Value::isFloat() const {
   return type == TypeFloat;
 }
-bool Value::isNumber() {
+bool Value::isNumber() const {
   return isInt() || isFloat();
 }
-bool Value::isBoolean() {
+bool Value::isBoolean() const {
   return type == TypeBoolean;
 }
-bool Value::isString() {
+bool Value::isString() const {
   return type == TypeString;
 }
-bool Value::isFunction() {
+bool Value::isFunction() const {
   return type == TypeFunction;
 }
-bool Value::isArgs() {
+bool Value::isArgs() const {
   return type == TypeArgs;
 }
-bool Value::isIdentifier() {
+bool Value::isIdentifier() const {
   return type == TypeIdentifier;
 }
 
diff --git a/src/types.h b/src/types.h
index fbf6510..40e7ec3 100644
--- a/src/types.h
+++ b/src/types.h
@@ -96,15 +96,26 @@ public:
   Value& operator=(const Value &rhs);
   ~Value();
 
-  bool isNil();
-  bool isInt();
-  bool isFloat();
-  bool isNumber();
-  bool isBoolean();
-  bool isString();
-  bool isFunction();
-  bool isArgs();
-  bool isIdentifier();
+  void cleanup();
+
+  Value& operator=(Nil rhs);
+  Value& operator=(long rhs);
+  Value& operator=(double rhs);
+  Value& operator=(bool rhs);
+  Value& operator=(const std::string &rhs);
+  Value& operator=(const Func &rhs);
+  Value& operator=(const Args &rhs);
+  Value& operator=(const Identifier &rhs);
+
+  bool isNil() const;
+  bool isInt() const;
+  bool isFloat() const;
+  bool isNumber() const;
+  bool isBoolean() const;
+  bool isString() const;
+  bool isFunction() const;
+  bool isArgs() const;
+  bool isIdentifier() const;
 
   void assertNil(Context &cxt);
   void assertInt(Context &cxt);